Skip to content

SWHC004 residential revision due to QC findings#117

Open
behzadsalimian wants to merge 13 commits intosound-data:mainfrom
simularis:dev-SWHC004-residential-qc
Open

SWHC004 residential revision due to QC findings#117
behzadsalimian wants to merge 13 commits intosound-data:mainfrom
simularis:dev-SWHC004-residential-qc

Conversation

@behzadsalimian
Copy link
Copy Markdown
Contributor

@behzadsalimian behzadsalimian commented Aug 7, 2025 •
edited
Loading

Pull Request (PR) Description

This PR addresses several outstanding issues for the SWHC004 Residential analysis workflow

  • Corrected unit conversion in insert_normunits.py (Watts to kBtu/h)
  • Ensured correct labeling of normalized units (CapOut-kBtuh)
  • Parametrized OA temperature resets
  • Updated techIDs names in the cases files

Contributor Email: brizi@solaris-technical.com

PR Review Checklist

PR Owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Bug and Feature
  • Assign a reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • See eTRM
  • For a new measure, add a summary table showing total energy consumption per simulated case.
  • See eTRM

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@behzadsalimian behzadsalimian changed the title Dev swhc004 residential qc SWHC004 residential revision due to QC findings Aug 7, 2025
simularis
simularis reviewed Aug 12, 2025
View reviewed changes
Comment thread ...ler/SWHC004-07 Space Heating Boiler_MFm_Ex/cases/MFm&0&rNCHW&Ex&SpaceHtg_eq__SteamBoiler.csv
Copy link
Copy Markdown
Contributor

@simularis simularis Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm name of boiler efficiency for this cohort. Previously steam_boiler_eff.

Copy link
Copy Markdown
Contributor Author

@behzadsalimian behzadsalimian Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed "boiler_eff" to "steam_boiler_eff" to match the defined parameter in the prototype.

@behzadsalimian behzadsalimian marked this pull request as draft August 18, 2025 04:23
@behzadsalimian behzadsalimian marked this pull request as ready for review August 18, 2025 05:15
@behzadsalimian behzadsalimian marked this pull request as draft August 18, 2025 05:15
simularis
simularis approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@simularis simularis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal review by Solaris Technical completed.

@behzadsalimian behzadsalimian marked this pull request as ready for review August 22, 2025 22:19
@behzadsalimian
Copy link
Copy Markdown
Contributor Author

behzadsalimian commented Oct 25, 2025

The techIDs for residential don't follow the naming convention to start with "RG" instead of "NG". We will not change unless specifically requested (to keep our simulation results matching with the GiHub).

sepideh-QEA
sepideh-QEA reviewed Apr 18, 2026
View reviewed changes
Comment thread scripts/data transformation/insert_normunits.py

# Specify a multipler, e.g. for a unit conversion.
kbtuh_per_watt = 3.412141633
kbtuh_per_watt = 0.003412 # Correct: W → kBtu/h
Copy link
Copy Markdown
Collaborator

@sepideh-QEA sepideh-QEA Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If sizing_multiplier is multiplied by a W value, 1/0.003412 ~ 293 is actually kBtu/h → W, not W → kBtu/h.
Even if test() isn’t used in production, this is misleading—please correct the example math/comment for QC readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sepideh-QEA sepideh-QEA sepideh-QEA left review comments

+1 more reviewer

@simularis simularis simularis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@behzadsalimian @simularis @sepideh-QEA @nfette